:hammer: Replace constant index access into a loop w/ dynamic index · FagnerMartinsBrack/jack-the-moneylender@4319849

GitHub 1 min read

This article is too short to summarise.

Original file line number	Diff line number	Diff line change
`@@ -24,16 +24,10 @@`
`24`	`24`
`25`	`25`	`let interestAmount = Money('$0.00');`
`26`	`26`
`27`		`-if (loanAmount.greaterThan(ranges[0].endOfRange)) {`
`28`		`-interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[0]));`
`29`		`-}`
`30`		`-`
`31`		`-if (loanAmount.greaterThan(ranges[1].endOfRange)) {`
`32`		`-interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[1]));`
`33`		`-}`
`34`		`-`
`35`		`-if (loanAmount.greaterThan(ranges[2].endOfRange)) {`
`36`		`-interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[2]));`
	`27`	`+for (let i = 0; i < ranges.length; i += 1) {`
	`28`	`+if (loanAmount.greaterThan(ranges[i].endOfRange)) {`
	`29`	`+interestAmount = interestAmount.plus(calculateInterest(loanAmount, ranges[i]));`
	`30`	`+}`
`37`	`31`	`}`
`38`	`32`
`39`	`33`	`return interestAmount;`