Readplace

:hammer: Rename function internals to have generic names · FagnerMartinsBrack/jack-the-moneylender@9c1093b

GitHub 1 min read
View original
  • current

This article is too short to summarise.

@@ -7,22 +7,22 @@

77

assert.strictEqual(actual, expected);

88

}

9910-

const calculateInterestForGreaterThan2000 = (loanAmount, endOfFirstRange, centsForSecondRange, centsForFirstRange) => {

11-

const dollarsAboveThresholdForGreaterThan2000 = loanAmount.minus(endOfFirstRange);

12-

const interestForGreaterThan2000 = centsForSecondRange.minus(centsForFirstRange).multipliedBy(dollarsAboveThresholdForGreaterThan2000);

13-

return interestForGreaterThan2000;

10+

const calculateInterestForGreaterThan2000 = (loanAmount, endOfRange, interestPerDollar, previousInterestPerDollar) => {

11+

const dollarsAboveThreshold = loanAmount.minus(endOfRange);

12+

const interestToPay = interestPerDollar.minus(previousInterestPerDollar).multipliedBy(dollarsAboveThreshold);

13+

return interestToPay;

1414

};

151516-

const calculateInterestForGreaterThan5000 = (loanAmount, endOfSecondRange, centsForThirdRange, centsForSecondRange) => {

17-

const dollarsAboveThresholdForGreaterThan5000 = loanAmount.minus(endOfSecondRange);

18-

const interestForGreaterThan5000 = centsForThirdRange.minus(centsForSecondRange).multipliedBy(dollarsAboveThresholdForGreaterThan5000);

19-

return interestForGreaterThan5000;

16+

const calculateInterestForGreaterThan5000 = (loanAmount, endOfRange, interestPerDollar, previousInterestPerDollar) => {

17+

const dollarsAboveThreshold = loanAmount.minus(endOfRange);

18+

const interestToPay = interestPerDollar.minus(previousInterestPerDollar).multipliedBy(dollarsAboveThreshold);

19+

return interestToPay;

2020

};

212122-

const calculateInterestForGreaterThan10000 = (loanAmount, endOfThirdRange, centsForFourthRange, centsForThirdRange) => {

23-

const dollarsAboveThresholdForGreaterThan10000 = loanAmount.minus(endOfThirdRange);

24-

const interestAmountForGreaterThan10000 = centsForFourthRange.minus(centsForThirdRange).multipliedBy(dollarsAboveThresholdForGreaterThan10000);

25-

return interestAmountForGreaterThan10000;

22+

const calculateInterestForGreaterThan10000 = (loanAmount, endOfRange, interestPerDollar, previousInterestPerDollar) => {

23+

const dollarsAboveThreshold = loanAmount.minus(endOfRange);

24+

const interestToPay = interestPerDollar.minus(previousInterestPerDollar).multipliedBy(dollarsAboveThreshold);

25+

return interestToPay;

2626

};

27272828

const interestToPayFor = (loanAmount) => {